Page MenuHomeMusing Studio
Create Task
Maniphest T645

Collection should default to username
Closed, WontfixPublic
Actions

Description

Currently with other instances, a new post is created under drafts. It should be the users name when no collection was specified.

Related Objects
Search...

Event Timeline

robjloranger triaged this task as Medium-High priority.Jun 12 2019, 2:17 AM
robjloranger created this task.
robjloranger moved this task from Backlog to In Progress on the WriteFreely CLI board.
robjloranger added a comment.Jun 12 2019, 2:37 AM

in go-writeas PostParams tells JSON to ignore the Collection field

robjloranger added a project: API Library: Go.Jun 12 2019, 2:39 AM
robjloranger moved this task from Backlog to Next Up on the API Library: Go board.
robjloranger removed a project: API Library: Go.Jun 13 2019, 3:06 AM

fixed upstream issue, v2.0.1

robjloranger moved this task from In Progress to Complete on the WriteFreely CLI board.Jun 13 2019, 3:06 AM
matt added a comment.Jun 13 2019, 1:12 PM

So, the PostParams.Collection field was left out of the JSON because it shouldn't ever get sent along with the payload. Instead it's used to set the API endpoint in go-writeas, e.g. /api/collections/{Collection}/posts. Is there another reason it's needed in the JSON?

robjloranger added a comment.Jun 13 2019, 1:50 PM

Sorry I missed that part. I admit I was eager to do some work yesterday.

The reason is it wasn't working without it present, which is weird. The posts still went up as drafts. I can test again using the previous version.

matt added a comment.Jun 13 2019, 1:53 PM

No worries. Yeah, the library should be taking the parameter and using it to change the endpoint, as is done here in post.go

robjloranger added a comment.Jun 13 2019, 1:54 PM

OK, let's revert that commit and I will test more to see what the real problem is.

matt added a comment.Jun 13 2019, 1:56 PM

Sounds good. I'll go ahead and revert it.

robjloranger added a comment.Jun 13 2019, 5:16 PM

ok, super strange but it does work now without the collection being sent.

matt closed this task as Wontfix.Sep 20 2019, 3:56 PM

As mentioned in this GitHub comment, we want to support posting drafts with wf-cli, so we don't want this behavior.

musing studio · developers